rokucommunity / rokucommunity/brighterscript

Give better fedback for addFiles api calls

Open
#198 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug plugin api
Dominant language
TypeScript
Stars
208
Forks
68
Avg merge
8h 39m
Merged PRs (30d)
39

Description

If files get added, with mangled source paths, such as including pkg: int the target path, the file appears added; but fails to have it's references taken into account on it's scope.

We should probs fail loudly; took me 15 minutes of head-scratching with source debugging, which would perturb other devs, I'm sure.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the addFiles API and reproduce the problem with a malformed target path containing pkg:. Trace how the added file is accepted and how its references are handled; done means the invalid path produces a clear failure instead of silently omitting scope references.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.