rokucommunity / rokucommunity/brighterscript

Watch mode errors on scope changes after transpilation

Open
#1,613 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
208
Forks
68
Avg merge
8h 39m
Merged PRs (30d)
39

Description

There's an issue with watch mode where field initialisers will trigger diagnostic errors after their scope is transpiled. This only happens after the app has already been transpiled.

Here's a unit test that shows the issue:

it('does not pollute the AST after validation', () => {
    const file = program.setFile<BrsFile>('source/lib.bs', `
        class HasPropertyInitialiser
            name as string = createObject("roString")
            sub new()
                super()
            end sub
        end class
    `);
    program.validate();
    file.transpile();
    program.setFile<BrsFile>('source/another.bs', `
        class AnotherClassJustToInvalidateScope
        end class
    `);
    program.validate();
    expectZeroDiagnostics(program.getDiagnostics());
});

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the supplied unit-test sequence using program.validate(), file.transpile(), program.setFile(), and program.getDiagnostics(). Reproduce the diagnostic errors after transpilation, then trace how validation and scope invalidation interact with the transpiled AST. Done means the test produces zero diagnostics after the second validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.