rokucommunity / rokucommunity/brighterscript

stray end function in class causes errors to not be reported

Open
#160 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
208
Forks
68
Avg merge
8h 39m
Merged PRs (30d)
39

Description

in this file with the extra end function towards, the end, there was no compile error reported - the output was garbled, and the compiler on the box failed.

import "pkg:/source/maestro/ioc/IOCMixin.bs"
import "pkg:/source/rLog/rLogMixin.brs"
import "pkg:/source/Mixins/AppService.bs"
import "pkg:/source/Mixins/NetMixin.bs"

namespace SMC
  class BaseClass

    public name as string

    function new(name)
      m.name = name
      registerLogger(name, true, m)
      MIOC.initClass(m)
      AppService.initClass(m)
    end function

    '+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    '++ graphQL api support
    '+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

    function getGraphQL(queryId, args = {}, callbackName = "", resultType = "node", isAsync = true, requestParams = {}) as object
      'note - all mixed in getGraphQL calls ARE SYNC
      return getGraphQL(queryId, args, callbackName, resultType, true, requestParams)
    end function

    function cancelRequest(request)
      cancelRequest(request)
    end function
  end function

end class

end namespace

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reducing the supplied BrightScript snippet to a parser or compiler test that includes the stray end function inside the class. Trace how the compiler handles the unmatched terminator and verify that compilation reports an error instead of producing garbled output or failing without a diagnostic.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.