rokucommunity / rokucommunity/brighterscript
source literals shouldn't have their own AST type
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 208
- Forks
- 68
- Avg merge
- 8h 39m
- Merged PRs (30d)
- 39
Description
Source literals should not have a dedicated expression type of SourceLiteralExpression. These work exactly the same as VariableExpression, so we should just use that. And then the list of known source literals can be handled in the validation and transpilation layers.
This is a breaking change, so we should do this before v1.0.0 lands.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing SourceLiteralExpression through the AST, validation, and transpilation layers, then compare it with VariableExpression. Done means source literals use VariableExpression and their known-literal handling resides in validation and transpilation, with the relevant existing tests passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100