rokucommunity / rokucommunity/brighterscript
instr method signature is incorrect
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 208
- Forks
- 68
- Avg merge
- 8h 39m
- Merged PRs (30d)
- 39
Description
There's an undocumented 2-argument version of instr and ifString.instr.
https://gw-basic.netlify.app/files/tuts/gw-man/index.html
We need to update the signature in brighterscript to support both.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked GW-BASIC manual entry and compare its two-argument instr form with the current BrightScript and ifString.instr signatures. Locate the builtin signature definitions and existing validation tests, then verify that both forms are accepted and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100