rokucommunity / rokucommunity/brighterscript

`FUNCTION_NAME` source literal doesn't work in class methods

Open
#1,436 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
208
Forks
68
Avg merge
8h 39m
Merged PRs (30d)
39

Description

Happens on both v0 and v1.

class MyClass
    sub myMethod()
        print FUNCTION_NAME
    end sub
end class

Transpiles to:

function __MyClass_builder()
    instance = {}
    instance.new = sub()
    end sub

    instance.myMethod = sub()
        print ""      ' <--- actually not sure what it should print... something like "MyClass::myMethod"?
    end sub
    return instance
end function

function MyClass()
    instance = __MyClass_builder()
    instance.new()
    return instance
end function

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the FUNCTION_NAME handling and the class-method transpilation path, then reproduce the MyClass example from the issue in the relevant compiler test setup. Determine the intended value for a method such as MyClass::myMethod and add coverage showing that the source literal is no longer emitted as an empty string.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.