rokucommunity / rokucommunity/brighterscript

proper manifest handling

Open
#1,026 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Breaking Change
Dominant language
TypeScript
Stars
208
Forks
68
Avg merge
8h 39m
Merged PRs (30d)
39

Description

In v1, we need to elevate manifest to a proper File type. Right now we load the manifest as a RawFile, but also separately load and parse the manifest in the Program._manifest collection. Program._manifest should go away in favor of having a reference to the ManifestFile instance that will be created.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing where the manifest is loaded as a RawFile and parsed into Program._manifest. Follow the creation and use of the proposed ManifestFile reference, then verify that Program._manifest is no longer needed and manifest handling remains functional across the existing test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.