rokucommunity / rokucommunity/brighterscript
stagingFolderPath and stagingDir....not working quite right
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 208
- Forks
- 68
- Avg merge
- 8h 39m
- Merged PRs (30d)
- 39
Description
We introduced stagingDir in https://github.com/rokucommunity/brighterscript/pull/706 but didn't actually do any forward-mapping to convert the old to the new...so stuff breaks. We need to properly handle copying stagingFolderPath into stagingDir if stagingDir isn't specified. Probably just do this in the util function that builds the bsconfigs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the util function that builds the bsconfigs and review the stagingDir introduction in pull request #706. Trace how stagingFolderPath and stagingDir are read, then make the fallback behavior use stagingFolderPath when stagingDir is not specified. Done means existing configurations using stagingFolderPath continue to work without breaking stagingDir.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100