rocq-prover / rocq-prover/stdlib
Naming conventions broken (cos/sin)
Open
Nobody has claimed this yet.
- Dominant language
- Rocq Prover
- Stars
- 42
- Forks
- 38
- Avg merge
- 14h 6m
- Merged PRs (30d)
- 3
Description
What happened to the naming conventions here? (These should be cos_3PI4 and sin_3PI4.)
Would the right fix be to add underscores (and potentially break things) or add aliases to the same lemmas with underscores?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in theories/Reals/Rtrigo_calc.v around lines 181-193 and inspect the existing cos/sin lemma names against the requested cos_3PI4 and sin_3PI4 forms. Decide whether compatibility requires aliases or renaming, then confirm the naming convention is addressed without leaving the issue's existing API question unresolved.
Written by the indexing model from the issue text.
Assessment
- Domain
- developer-experience
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100