rocky / rocky/python-xdis

Add a more flexible way to adjust Magic or deal with new/alternate magic numbers.

Open
#70 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement Volunteer wanted to fix
Dominant language
Python
Stars
371
Forks
106
PR merge metrics
No merged PRs in 30d

Description

Right now xdis needs to be update every time a new Python release comes out. This is by design because we do want to have this program be a reference on valid Python's rather than hypothetical ones.

However one proble is that right now we can only handle one magic number per Python version and sometimes for a given Python version there can be more than one. See for example #69.

Propose and implement a way to accomodate these problems.

One possibility is to add a parameter to override the built-in magic to Python mappings. And an option to pydisasm could allow a magic number override.

No doubt there are a number of other possibilityes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the built-in magic-to-Python mappings and the pydisasm entry point, then inspect issue #69 for the alternate-magic case. Define how multiple magic numbers per Python version and optional overrides should work before implementing; done means new releases and alternate magics can be handled without updating the library each time.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.