robotframework / robotframework/SeleniumLibrary

Copy any received files (and corresponding approved files) to results folder

Open
#1,883 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

Occasionally there are errors within the approvaltests unit tests. These unit tests do post processing against know reults. When an eror occurs then the syst outputs the received files along side the files showing what was expected or the approved files. Like these

approved_file = '/home/runner/work/SeleniumLibrary/SeleniumLibrary/utest/test/keywords/approved_files/test_selenium_options_parser.test_split_options.approved.txt'
received_file = '/home/runner/work/SeleniumLibrary/SeleniumLibrary/utest/test/keywords/approved_files/test_selenium_options_parser.test_split_options.received.txt'

Notice that the file directory for these is not under the atest/results folder which our GitHub Action workflow will zip and archive. I am wondering if it is worth saving these files as part of that archive? (Actually is there is an unit test failure within GitHub actions we might also have the issue that there is no results folder because we never run the atests. might be a secondary problem to looks at as well.)

Recording here as a reminder to look into this ..

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the ApprovalTests unit-test post-processing and the GitHub Action workflow that archives the atest/results folder. Reproduce a failure, then verify that received files and their corresponding approved files are copied into the archived results; separately check the case where atests are not run and the results folder does not exist.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, python
Domain
ci-cd, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.