robotframework / robotframework/SeleniumLibrary

"Table Footer Should Contain" should take into account <th> elements

Open Beginner friendly
#1,436 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

Table Footer Should Contain is always looking for <td> tag within <tfoot>:

https://github.com/robotframework/SeleniumLibrary/blob/44a41f0a8ce719c928cd9d7fe7b33b3998006ee3/src/SeleniumLibrary/keywords/tableelement.py#L202-L203

but it's valid to have <th> tags there also. Example: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tfoot

Can we have this keyword fixed to take into account <th> tags as well?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/SeleniumLibrary/keywords/tableelement.py at the Table Footer Should Contain implementation around lines 202–203. Reproduce the keyword with a valid containing elements, then verify that footer tables using either or are accepted.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, python
Domain
testing-qa, web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.