robotframework / robotframework/RIDE
Do not normalise tag names in View All Tags dialog
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 385
- Avg merge
- 13m
- Merged PRs (30d)
- 2
Description
Framework Version: 2.8.7
Python: 2.7
Operating System: Win 7 Enterprise
Using RIDE 1.3
If I have tag:
TableCleanUp
on one test, and:
Table CleanUp
on another test, when I select Tools -> View All Tags, nothing happens. I hooked RIDE into an IDE, and got the following:
Connected to pydev debugger (build 135.1057)
Traceback (most recent call last):
File "C:\DeploymentUnit\Anaconda\Lib\site-packages\robotframework_ride-1.3-py2.7-win32.egg\robotide\ui\actiontriggers.py", line 379, in call
action.act(event)
File "C:\DeploymentUnit\Anaconda\Lib\site-packages\robotframework_ride-1.3-py2.7-win32.egg\robotide\action\action.py", line 86, in act
self.action(event)
File "C:\DeploymentUnit\Anaconda\Lib\site-packages\robotframework_ride-1.3-py2.7-win32.egg\robotide\utils\eventhandler.py", line 22, in wrapped
method(self, event)
File "C:\DeploymentUnit\Anaconda\Lib\site-packages\robotframework_ride-1.3-py2.7-win32.egg\robotide\ui\mainframe.py", line 248, in OnViewAllTags
self._view_all_tags_dialog.show_dialog()
File "C:\DeploymentUnit\Anaconda\Lib\site-packages\robotframework_ride-1.3-py2.7-win32.egg\robotide\ui\tagdialogs.py", line 114, in show_dialog
self._execute()
File "C:\DeploymentUnit\Anaconda\Lib\site-packages\robotframework_ride-1.3-py2.7-win32.egg\robotide\ui\tagdialogs.py", line 92, in _execute
self._search_for_tags()
File "C:\DeploymentUnit\Anaconda\Lib\site-packages\robotframework_ride-1.3-py2.7-win32.egg\robotide\ui\tagdialogs.py", line 139, in _search_for_tags
self._tagit[tag_name].append(tag)
KeyError: u'Table CleanUp'
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in robotide/ui/tagdialogs.py, especially _search_for_tags(), and reproduce the View All Tags action with the two distinct tag names shown in the report. Trace how tag names are stored before the KeyError occurs. Done means the dialog opens and displays both tag names without normalising them or raising the reported error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100