How to handle cropping in `workflows`?
Open
Nobody has claimed this yet.
question
- Dominant language
- Python
- Stars
- 2.5k
- Forks
- 320
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 133
Description
Search before asking
- I have searched the Inference issues and found no similar feature requests.
Question
We have Crop block to create dynamic blocs, we do also have static crops (absolute and relative).
There are few questions we need to answer:
- Could we possibly merge that?
- Do we need absolute and relative?
- What is the naming convention? Probably (as suggested here) having
staticdemands havingdynamiccrop
Additional
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing Crop block and the static absolute and relative crop implementations in the workflows system. Review the discussion in pull request #343, especially the naming suggestion. Done means reaching a decision on whether to merge the crop types, whether both static modes are needed, and how static and dynamic crops should be named.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-vision
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100