roboflow / roboflow/inference

Keypoints kind

Open
#401 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.5k
Forks
320
Avg merge
1d 14h
Merged PRs (30d)
133

Description

Following up below code review comment:

[loud thinking] I am generally in favour of having sv.Detections for all detections-based use cases, but supervision itself seems to diverge from that idea. In the latest release we got new abstraction sv.KeyPoints which do not hold bboxes, and is invariant on "different skeleton for different class" topic - which makes it not 100% suitable for our usage now.
I propose to keep as is for now, but we need to have discussion what to do next - definitely we need support for multiple skeletons (this is in general good change for supervision as this makes the abstraction more robust), but I would say that's suboptimal to loose info about Bounding Boxes when model provides them - maybe we could have both data outputs later in the future - one of Object Detection kind and another of Keypoints kind

Originally posted by @PawelPeczek-Roboflow in https://github.com/roboflow/inference/pull/392#discussion_r1602751208

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked PR #392 discussion and the referenced supervision/keypoint/core.py implementation. Review how keypoints currently represent bounding boxes and skeletons, then clarify the desired output abstraction and support for multiple skeletons. Done requires an agreed design and a concrete, documented scope before implementation can begin.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-vision
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.