[Bug]: `setCamera` with bounds and padding applies "ghost padding" after other `setCamera` with padding
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 2.9k
- Forks
- 947
- Avg merge
- 6d 37m
- Merged PRs (30d)
- 1
Description
Mapbox Version
11.20.3
React Native Version
0.85.3
Platform
iOS
@rnmapbox/maps version
10.3.1
Standalone component to reproduce
import React, { useRef } from 'react';
import { View, Button, StyleSheet } from 'react-native';
import MapboxGL from '@rnmapbox/maps';
const POINTS = [
[-123.1207, 49.2827], // SW
[-123.1107, 49.2827], // SE
[-123.1107, 49.2927], // NE
[-123.1207, 49.2927], // NW
];
const BOUNDS = {
ne: [-123.1107, 49.2927],
sw: [-123.1207, 49.2827],
};
export default function CameraPaddingRepro() {
const cameraRef = useRef<MapboxGL.Camera>(null);
// Step 1: Center on the SW point with 500px bottom padding
const handleFlyTo = () => {
cameraRef.current?.setCamera({
centerCoordinate: POINTS[0],
zoomLevel: 15,
padding: {
paddingTop: 0,
paddingRight: 0,
paddingLeft: 0,
paddingBottom: 500, // Large bottom padding (e.g., simulated sheet open)
},
animationDuration: 1000,
});
};
// Step 2: Fit bounds with small bottom padding (e.g., sheet closed or small detent)
const handleFitBounds = () => {
cameraRef.current?.setCamera({
bounds: BOUNDS,
padding: {
paddingTop: 0,
paddingRight: 0,
paddingLeft: 0,
paddingBottom: 0, // Reset bottom padding to small value
},
animationDuration: 1000,
});
};
// Step 3: Fit bounds with big negative bottom padding (e.g., sheet open or large detent)
const handleFitBoundsNegativePadding = () => {
cameraRef.current?.setCamera({
bounds: BOUNDS,
padding: {
paddingTop: 0,
paddingRight: 0,
paddingLeft: 0,
paddingBottom: -500, // Large negative bottom padding
},
animationDuration: 1000,
});
};
return (
<View style={styles.container}>
<MapboxGL.MapView style={styles.map}>
<MapboxGL.Camera
ref={cameraRef}
defaultSettings={{ zoomLevel: 10, centerCoordinate: POINTS[0] }}
/>
{/* Render the 4 points so you can visually see the framing */}
<MapboxGL.ShapeSource
id="points"
shape={{
type: 'FeatureCollection',
features: POINTS.map((coord, idx) => ({
type: 'Feature',
id: `pt-${idx}`,
geometry: { type: 'Point', coordinates: coord },
properties: {},
})),
}}
>
<MapboxGL.CircleLayer
id="circles"
style={{ circleRadius: 10, circleColor: 'red' }}
/>
</MapboxGL.ShapeSource>
</MapboxGL.MapView>
<View style={styles.buttonContainer}>
<Button title="1. FlyTo SW (500 Padding)" onPress={handleFlyTo} />
<Button title="2. Fit Bounds (No Padding)" onPress={handleFitBounds} />
<Button
title="3. Fit Bounds (Big Negative Padding)"
onPress={handleFitBoundsNegativePadding}
/>
</View>
</View>
);
}
const styles = StyleSheet.create({
container: { flex: 1 },
map: { flex: 1 },
buttonContainer: {
position: 'absolute',
bottom: 50,
left: 20,
right: 20,
backgroundColor: 'white',
padding: 10,
borderRadius: 8,
flexDirection: 'column',
justifyContent: 'space-around',
},
});
Observed behavior and steps to reproduce
Press the buttons in order. The first setCamera sets a center-point with a large amount of bottom padding added. This is to simulate a map with a bottom sheet over it (or similar). Pressing #2 shows that sending setCamera with explicit padding does not behave as expected. The padding from the previous command is remembered and added. #3 shows that applying a large negative padding opposite to the original padding does what we actually expected from #2.
Expected behavior
setCamera with padding should set the padding defined in the params.
Notes / preliminary analysis
No response
Additional links and references
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Camera component's setCamera entry point and reproduce the sequence in the linked minimal reproduction repo on iOS. Trace how padding is retained across the three calls, then verify that an explicit padding value replaces the previous value and that the reproduction no longer shows ghost padding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, javascript, react-native
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100