rnmapbox / rnmapbox/maps

[Bug]: Missing type exports

Open
#4,139 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug 🪲
Dominant language
Kotlin
Stars
2.9k
Forks
947
Avg merge
6d 37m
Merged PRs (30d)
1

Description

Mapbox Implementation

Mapbox

Mapbox Version

11.15.0

React Native Version

0.83.1

React Native Architecture

New Architecture (Fabric/TurboModules)

Platform

iOS

@rnmapbox/maps version

10.2.10

Standalone component to reproduce
import {Expression} from '@rnmapbox/maps/src/utils/MapboxStyles';
const myExpression: Expression = ['get', 'myProp']
Observed behavior and steps to reproduce

On the new version, this has to be imported with
node_modules/ as a prefix -> import {Expression} from 'node_modules/@rnmapbox/maps/src/utils/MapboxStyles'

Expected behavior

Import without node_modules/ prefix.

Notes / preliminary analysis

Same thing needed for type imports from these paths:
node_modules/@rnmapbox/maps/src/components/SymbolLayer
node_modules/@rnmapbox/maps/src/utils/MapboxStyles
node_modules/@rnmapbox/maps/src/components/MapView
node_modules/@rnmapbox/maps/src/types/OnPressEvent

Unless I'm doing something wrong?

Additional links and references

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the type imports and source paths listed in the issue: SymbolLayer, MapboxStyles, MapView, and OnPressEvent. Check how these modules are exposed by the package and reproduce the import in the provided TypeScript example. Done means the types import without a node_modules prefix on @rnmapbox/maps 10.2.10.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
developer-experience, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.