rnmapbox / rnmapbox/maps

[Bug]: iOS PointAnnotation need to "longpress" before you can start dragging it on the map, on Android you can drag immediately after Press/Tap

Open
#3,425 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug 🪲
Dominant language
Kotlin
Stars
2.9k
Forks
947
Avg merge
6d 37m
Merged PRs (30d)
1

Description

Mapbox Implementation

Mapbox

Mapbox Version

default

React Native Version

0.70.8

Platform

iOS

@rnmapbox/maps version

10.1.15

Standalone component to reproduce
import React, {useState, useRef} from 'react';
import {
    StyleSheet,
} from 'react-native';

import MapboxGL from "@rnmapbox/maps";

const PointAnnotationBugIos = (props) => {
  const mapboxCamera = useRef(null);
  const mapboxMap = useRef(null);
  const editablePolygonPointsRef = useRef([]);

  const [geofenceEditCoords, setGeofenceEditCoords] = useState([[8.966282182525784, 45.63315618252579], [8.966282182525784, 45.63282321747422], [8.965949217474215, 45.63282321747422], [8.965949217474215, 45.63315618252579]]);
  const [propertyCenter, setPropertyCenter] = useState([8.966115, 45.6329897]);

  const draggingEditablePoint = (index, feature) => {
    const updatedCoordinates = [...geofenceEditCoords];
    updatedCoordinates[index] = feature.geometry.coordinates;
    setGeofenceEditCoords(updatedCoordinates)
  };

  const changeCoordinate = (index, feature) => {
    let newCoord = [feature.geometry.coordinates[0], feature.geometry.coordinates[1]];
    let newPolygonCoords = [...geofenceEditCoords];
    newPolygonCoords.splice(index, 1);
    newPolygonCoords.splice(index, 0, newCoord);

    if (geofenceEditCoords) {
      setGeofenceEditCoords(newPolygonCoords) 
    }
  }

  return (
    <>
      <MapboxGL.MapView 
        ref={mapboxMap}
        style={{...StyleSheet.absoluteFillObject}}
        attributionEnabled={false}
        scaleBarEnabled={false}
        compassEnabled={false}
        pitchEnabled={false}>
        <MapboxGL.Camera
          ref={mapboxCamera}
          zoomLevel={18}
          minZoomLevel={15}
          maxZoomLevel={20}
          centerCoordinate={propertyCenter} />

        {geofenceEditCoords!==null && geofenceEditCoords && geofenceEditCoords.length>0 ? 
            <MapboxGL.ShapeSource
              key={"keyPolygonElem"}
              id={"keyPolygonElem"}
              shape={
                  geofenceEditCoords.length>3 ?
                    { type: 'FeatureCollection', features: [{ type: 'Feature', geometry: { type: 'Polygon', coordinates: [geofenceEditCoords] } }] } :
                    geofenceEditCoords.length>1 ? 
                      { type: 'FeatureCollection', features: [{ type: 'Feature', geometry: { type: 'LineString', coordinates: geofenceEditCoords } }] } :
                      { type: 'FeatureCollection', features: [{ type: 'Feature', geometry: { type: 'Point', coordinates: geofenceEditCoords[0] } }] }
                  }>
                  <MapboxGL.FillLayer 
                      key="keyPolygon-fill" 
                      id="keyPolygon-fill" 
                      sourceID="keyPolygonElem"
                      style={{fillColor: 'rgba(0,0,0,0.2)'}} />
                  <MapboxGL.LineLayer
                    sourceID="keyPolygonElem"
                    id="keyPolygon-stroke"
                    key="keyPolygon-stroke"
                    style={{
                        lineColor: 'rgba(47,182,250,0.7)', 
                        lineWidth: 10,
                        lineJoin: 'round'
                      }} />
            </MapboxGL.ShapeSource> : null }
        {geofenceEditCoords!==null && geofenceEditCoords && geofenceEditCoords.length>0 ? 
            geofenceEditCoords.map((coordinate, index) => {
                editablePolygonPointsRef.current[index] = editablePolygonPointsRef.current[index] || React.createRef();
                return (<MapboxGL.PointAnnotation
                    key={"editablePoint_"+index}
                    id={"editablePoint_"+index}
                    ref={editablePolygonPointsRef.current[index]}
                    coordinate={coordinate}
                    selected={true}
                    draggable={true}
                    style={{ zIndex: 2000 }}
                    onDrag={(feature) => draggingEditablePoint(index, feature)}
                    onDragEnd={(feature) => changeCoordinate(index, feature)}></MapboxGL.PointAnnotation>)
            }) : null}
      </MapboxGL.MapView>
    </>
  );
}

export default PointAnnotationBugIos;
Observed behavior and steps to reproduce

On iOS, try to drag one PointAnnotation, if you press and try to drag all the map start to scrolling and the PointAnnotation will not move.
To make PointAnnotation moving you need to LongPress on it (at least 1 second), than if you drag it, it start moving.

Secondly, all PointAnnotations appear to be at a level below the LineLayer, they should be on top level as happens on Android.

Expected behavior

Expected behavior is the same that works running this code on Android.
When you try to drag one PointAnnotation it starts moving immediately after pressing it and dragging, you don't need to long press on it.

Secondly, here on Android, all PointAnnotations appear to be at the top level, over the LineLayer.

Notes / preliminary analysis

Note that this code works as expected on Android but not on iOS.

Additional links and references

Video that show how it works correctly on Android: drag start immediately after press and PointAnnotation above LineLayer.
https://github.com/rnmapbox/maps/assets/107206974/dbb9a22e-75db-458b-83fa-d4c5e0f7532a

On iOS you need to longpress before you can start dragging and PointAnnotation are below LineLayer
PointAnnotation-below-linelayer-ios

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the standalone PointAnnotation reproduction in the issue and compare its iOS behavior with Android. Investigate the drag interaction and rendering order for PointAnnotation relative to LineLayer. Done means dragging begins immediately after press on iOS and annotations render above the line layer, matching Android.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, javascript, react-native
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.