rmosolgo / rmosolgo/graphql-ruby
Generated `handle_error_in_development` doesn't work with stream/defer
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 5.4k
- Forks
- 1.4k
- Avg merge
- 23h 19m
- Merged PRs (30d)
- 28
Description
If ActionController::Live has already started a streaming response, then you call render, the server process gets very messed up and you have to kill it and restart it. It should somehow detect whether the stream has been written to and use response.stream.write in that case.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the generated handle_error_in_development implementation and the ActionController::Live streaming path. Reproduce a request that writes to the stream before calling render, then verify that the process remains usable and the response uses response.stream.write when the stream has already been written to.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100