rmosolgo / rmosolgo/graphql-ruby

Feature request to add a flag to identify if a list was scoped

Open
#5,051 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
5.4k
Forks
1.4k
Avg merge
23h 19m
Merged PRs (30d)
28

Description

This is a feature request to add a flag to an object specifying if the list was scoped. This would make it easier to check if the items returned from the scoped_items function were scoped and therefore no artifical clone would be required.

I'm open to adding some kind of flag method on the returned object, something like graphql_list_was_scoped?, and checking that inside GraphQL-Ruby. (I'd rather not go for multiple return ... in places where I've used that, it has added overhead and complexity 😩 )

Originally posted by @rmosolgo in https://github.com/rmosolgo/graphql-ruby/pull/3994#issuecomment-2265575031

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the scoped_items entry point and the object it returns in GraphQL-Ruby. Determine where the implementation can record whether scoping occurred, then inspect the surrounding behavior to define how callers should observe that state and avoid an artificial clone. Done means the returned object exposes the agreed flag consistently and the existing scoped-list behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.