rivet-dev / rivet-dev/dynamic-apps

Conformance: Error code properties (ERR_*) missing from polyfill errors

Open
#28 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
1k
Forks
51
Avg merge
6m
Merged PRs (30d)
13

Description

Upstream Node.js tests expect errors thrown by built-in modules to have a code property (e.g., ERR_INVALID_ARG_TYPE). Our polyfills throw plain TypeError/RangeError without the code property.

Affected modules: path, assert, buffer, url, querystring, util, fs.

Tracked via conformance test exclusions (category: implementation-gap).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the conformance test exclusions for the implementation-gap category and inspect the polyfills for path, assert, buffer, url, querystring, util, and fs. Compare their thrown errors with the upstream Node.js expectations; done means the affected errors expose the expected code properties and the exclusions are no longer needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
backend, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.