rivet-dev / rivet-dev/agentos

Replace the Rust curl shim with real curl

Open
#1,550 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
4.6k
Forks
251
Avg merge
2d 15h
Merged PRs (30d)
34

Description

Today curl in the VM is a Rust reimplementation (secure-exec/registry/native/crates/commands/curl, shipped as @agentos-software/curl, source: "rust"), not real curl. It diverges from curl's CLI — e.g. it rejects a bare hostname:

:/$ curl google.com
curl: unsupported argument `google.com`

Real curl normalizes google.comhttp://google.com; the shim does not, and likely lacks many flags/behaviors.

Goal: ship real curl so behavior matches upstream.

Options

  1. Compile real curl (C) to wasm32-wasip1 with libcurl + a TLS backend (wasi-compatible mbedTLS/wolfSSL/BearSSL), packaged like the other C registry commands. Highest fidelity, most effort (TLS-on-WASI is the hard part).
  2. Close the gap in the Rust shim as an interim: scheme normalization for bare hosts, common flags (-X, -H, -d, -o, -L, -s, -I), correct exit codes.

Recommendation: do (2) as a quick fix now (covers the reported breakage), track (1) as the real solution.

Implementation lives in secure-exec registry/software/curl + registry/native. Surfaced from just shell testing.

Related: the WARN could not retrieve pid for child process line also leaks into shell output on this path (separate shell-stripper bug).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in secure-exec/registry/software/curl and secure-exec/registry/native, then run the curl path from just shell. Determine whether the interim Rust shim or the real curl WASI packaging is in scope. Done means bare hostnames and the stated common flags behave like curl, with correct exit codes and without conflating the separate shell-stripper warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, rust, wasm
Domain
build-system, cli, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.