`FinalizedAt` struct field is not set on `Job` for cancelled events
Open
Nobody has claimed this yet.
bug
- Dominant language
- Go
- Stars
- 5.7k
- Forks
- 179
- Avg merge
- 15h 43m
- Merged PRs (30d)
- 13
Description
I'm subscribing to terminal job states:
ch, cancel := rc.Subscribe(
river.EventKindJobFailed,
river.EventKindJobCancelled,
river.EventKindJobCompleted)
And I noticed that the FinalizedAt struct field for Job is nil when the job is cancelled. This is confusing because other parts of the code seem to suggest that Finalized includes cancelled jobs so I would expect it to be set.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Finalized display logic in ui/src/components/JobList.tsx around line 174, then trace how cancelled job events populate the Go Job struct and FinalizedAt. Confirm the behavior for EventKindJobCancelled alongside failed and completed events; done means cancelled jobs expose a non-nil FinalizedAt consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100