rive-app / rive-app/rive-runtime
Command queue api includes unnessary headers
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.2k
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
In command_queue.hpp, neither viewmodel_runtime.hpp nor file_asset_loader.hpp are used.
#include "rive/object_stream.hpp"
#include "rive/refcnt.hpp"
#include "rive/math/vec2d.hpp"
#include "rive/viewmodel/runtime/viewmodel_runtime.hpp"
...
#include "file_asset_loader.hpp"
By having them there, it requires an api to include lots more files, and manually trying to do so is hard.
The end result is that all headers will be copied.
It does seem that command_queue.hpp should include rive/data_bind/data_values/data_type.hpp though.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with command_queue.hpp and inspect whether viewmodel_runtime.hpp and file_asset_loader.hpp are referenced there. Check the existing includes against the reported need for rive/data_bind/data_values/data_type.hpp. Done means the header exposes only the dependencies it uses and includes the required data type directly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100