rive-app / rive-app/rive-runtime

Cannot build skia renderer

Open
#39 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

triage
Dominant language
C++
Stars
1.2k
Forks
121
PR merge metrics
No merged PRs in 30d

Description

I tried to build the skia renderer (per the README.md), but it fails on building libpng.
I'm on arm64-macos, using Xcode 16.3 Beta.

Build:

$ cd skia/dependencies
$ ./make_skia.sh

Output:

[12/1097] compile ../../third_party/externals/libpng/pngrutil.c
FAILED: obj/third_party/externals/libpng/libpng.pngrutil.o 
cc -MD -MF obj/third_party/externals/libpng/libpng.pngrutil.o.d -DPNG_SET_OPTION_SUPPORTED -DNDEBUG  -w -Wno-attributes -fstrict-aliasing -fPIC -fvisibility=hidden -isysroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS18.4.sdk -arch arm64 -arch arm64e -O3 -fno-rtti -fembed-bitcode -mios-version-min=10.0 -flto=full -DSK_DISABLE_SKPICTURE -DSK_DISABLE_TEXT -DRIVE_OPTIMIZED -DSK_DISABLE_LEGACY_SHADERCONTEXT -DSK_DISABLE_LOWP_RASTER_PIPELINE -DSK_FORCE_RASTER_PIPELINE_BLITTER -DSK_DISABLE_AAA -DSK_DISABLE_EFFECT_DESERIALIZATION -isystem /Users/mathiaswesterdahl/work/external/rive-runtime/skia/dependencies/skia_rive_optimized/third_party/libpng -isystem /Users/mathiaswesterdahl/work/external/rive-runtime/skia/dependencies/skia_rive_optimized/third_party/externals/libpng -isystem /Users/mathiaswesterdahl/work/external/rive-runtime/skia/dependencies/skia_rive_optimized/third_party/externals/zlib  -c ../../third_party/externals/libpng/pngrutil.c -o obj/third_party/externals/libpng/libpng.pngrutil.o
In file included from ../../third_party/externals/libpng/pngrutil.c:17:
../../third_party/externals/libpng/pngpriv.h:527:16: fatal error: 'fp.h' file not found
  527 | #      include <fp.h>
      |                ^~~~~~

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with README.md and run skia/dependencies/make_skia.sh on arm64-macos using the reported Xcode setup. Inspect the libpng build around third_party/externals/libpng/pngpriv.h line 527 and the missing fp.h error. Done means the Skia renderer dependencies build successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, macos
Domain
build-system, computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.