rive-app / rive-app/rive-react-native

Passing incorrect animationName

Open
#259 2 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
783
Forks
81
Avg merge
3d 6h
Merged PRs (30d)
3

Description

Hi,

This is a very common issue, i dunno if i'm the only one who gets it but,

once you pass the animationName incorrectly to the ref methods, the app is crashing.

In the .riv files sometimes the animation names can be uppercase or camel case, so we need some sort of fix to handle this situation. Like checking or converting both requested and existing animations names to lowercase.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the ref methods that consume animationName and inspect how names from .riv files are matched. Reproduce the crash with an incorrectly cased animationName, then verify that valid names with differing case no longer crash and that the relevant tests cover the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.