rive-app / rive-app/rive-android
ImageProperty support for CommandQueue based ViewModelInstance
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 538
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
Thank you for the recent Jetpack Compose support announcement 🚀
While playing around with RiveUi noticed that there is no support for PropertyDataType.ASSET_IMAGE in ViewModelInstance. It used to be available in previously, like this ViewModeInstance#getImageProperty.
Q: Can we expect ImageProperty support for CommandQueue based ViewModelInstance soon?
As Jetpack Compose based Rive is still experimental, I would imagine it's still under development?
Thank you in advance!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in kotlin/src/main/kotlin/app/rive/RiveUI.kt and app/rive/ViewModelInstance.kt, then compare the CommandQueue-based implementation with the older getImageProperty implementation at kotlin/src/main/java/app/rive/runtime/kotlin/core/ViewModelInstance.kt#L154. Done means PropertyDataType.ASSET_IMAGE is supported through an ImageProperty on the CommandQueue-based ViewModelInstance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100