rive-app / rive-app/rive-android

Review all "wrapped" cpp objects, to be sure they are not leaked

Open
#267 0 comments 1 reaction 1 assignee View on GitHub

@umberto-sonnino is already working on this.

Since Jul 5, 2022.

Dominant language
Kotlin
Stars
538
Forks
66
No merged PRs in 30d

Description

At the time of writing, it appears that File and ArtboardInstance already have finalizers, but LinearAnimationInstance and StateMachineInstance did not.

Did not review any misc object types (e.g. AABB, Vec2D, Mat2D, ...)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.