ring-clojure / ring-clojure/ring
Make :headers optional in the Ring SPEC Response
Nobody has claimed this yet.
- Dominant language
- Clojure
- Stars
- 3.9k
- Forks
- 528
- PR merge metrics
- No merged PRs in 30d
Description
Setting :headers is mandatory in the Ring SPEC for responses. As it is effectively the same as not setting the :headers at all (which is both less code & faster), I propose it's made optional. This would not be even a breaking change?
In the era of clojure.spec and ring-spec, we get failures for this.
Related: https://github.com/metosin/reitit/issues/83#issuecomment-390884995
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the response requirements in the linked Ring SPEC, then inspect the ring-spec validation context referenced in the issue. Confirm how responses without :headers are handled and update the relevant specification and checks; done means such responses conform without failures while existing header behavior remains valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100