rigetti / rigetti/qcs-sdk-rust
Conversion between InstructionSetArchitecture and CompilerISA is lossy
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 15
- Forks
- 4
- Avg merge
- 1h 9m
- Merged PRs (30d)
- 1
Description
The openapi schema generated for rust has a lot of f32 where it ought to be f64. For example, the value of a characteristic maps to the operation “fidelity” in quilc, where it is expected to be an f64.
This isn’t a show-stopping problem, since the Python bindings take in a compiler ISA which has the correct type. For non-pyquil users, however, the compiler ISA is not readily accessible (in pyquil it is derived from the QCS ISA). The QCS ISA, on the other hand, is something anyone can get from the QCS API, and so we ought to support that type. If/when we do, we’ll need to fix the f32 types in the openapi model.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the generated model in src/models/characteristic.rs, especially the value field linked in the issue, and compare the QCS ISA and Compiler ISA representations. Trace how the QCS ISA is converted for non-Python users; done means the conversion is not lossy and fields such as fidelity retain the required f64 type.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- openapi, rust
- Domain
- api, backend-api-design
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100