richardcase / richardcase/clowder

Add Rust formatting, Clippy, and ShellCheck gates to CI

Open
#142 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement github_actions priority: medium rust
Dominant language
Rust
Stars
0
Forks
0
Avg merge
1h 14m
Merged PRs (30d)
16

Description

Problem

CI runs Rust tests but does not enforce formatting or lint cleanliness. On the audited snapshot, cargo fmt --check reports widespread drift and strict Clippy reports five diagnostics; ShellCheck also reports a warning in check-copy-claims.sh.

Evidence: https://github.com/richardcase/clowder/blob/b5492d5/.github/workflows/ci.yml#L215-L220

Acceptance criteria

  • Add a pinned-toolchain cargo fmt --check job.
  • Add a deliberate Clippy policy and fix or explicitly allow current diagnostics.
  • Run ShellCheck for repository scripts.
  • Keep failures actionable and avoid making release checks dependent on unpinned toolchain changes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/workflows/ci.yml around lines 215-220 and inspect the repository scripts, including check-copy-claims.sh. Run cargo fmt --check, strict Clippy, and ShellCheck on the audited snapshot to confirm the reported findings. Done means pinned-toolchain formatting enforcement, an explicit Clippy policy, ShellCheck coverage, and actionable failures without unpinned release dependencies.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, rust, shell
Domain
build-system, ci-cd, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.