rhobs / rhobs/observability-operator

MonitoringStack errors on quota for thanos-sidecar pod

Open
#528 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
51
Forks
90
Avg merge
5d 15h
Merged PRs (30d)
22

Description

Hello,

We have an issue with Cluster Observability Operator, in particular when creating MonitoringStack.
For example when using this yaml:

apiVersion: monitoring.rhobs/v1alpha1
kind: MonitoringStack
metadata:
  labels:
    mso: test-prometheus
  name: test-monitoring-stack
  namespace: test-monitoring
spec:
  alertmanagerConfig:
    disabled: true
  namespaceSelector:
    matchExpressions:
      - values:
          - test-monitoring
        key: kubernetes.io/metadata.name
        operator: In
  logLevel: debug
  resourceSelector:
    matchLabels:
      app: test-metrics
  retention: 1d

The Monitoring Stack is created and in Resources tab we can see:

"test-monitoring-stack-prometheus"
"test-monitoring-stack-prometheus-additional-scrape-configs"
"test-monitoring-stack-thanos-sidecar"
 

The problem is, that prometheus pods cannot start, because we get the following error:
"create Pod prometheus-test-monitoring-stack-0 in StatefulSet prometheus-test-monitoring-stack failed error: pods "prometheus-test-monitoring-stack-0" is forbidden: failed quota: test-monitoring-quota-compute-resources: must specify limits.cpu for: thanos-sidecar; limits.memory for: thanos-sidecar; requests.cpu for: thanos-sidecar; requests.memory for: thanos-sidecar"

We cannot find any documentation/instructions/guide on how to setup the limits for thanos-sidecar, because changing "resources" in the monitoringstack yaml only changes the limits for PROMETHEUS pods, but not thanos-sidecar.

Additionally, in our case we don't even need thanos-sidecar and would like to disable it completely like we can disable "alertmanager".

Thank you!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the MonitoringStack entry point and reproduce the provided YAML in a namespace with the shown resource quota. Trace how the Prometheus pod's thanos-sidecar is configured; done when its quota requirements can be configured or the sidecar can be disabled, with the documented behavior reflected in tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.