rhobs / rhobs/observability-operator

The API for setting resource isn't convenient

Open
#279 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
51
Forks
90
Avg merge
5d 15h
Merged PRs (30d)
22

Description

.spec.resources's description says "Define resources requests and limits for Monitoring Stack Pods" which is misleading because the resources requests are only applied to the Prometheus resource and we have no way to define requests for Alertmanager.

Instead of

spec:
  resources:
    requests:
      cpu: 200m
      memory: 1Gi

The API should probably look like

spec:
  prometheusConfig:
    resources:
      requests:
        cpu: 200m
        memory: 1Gi
  alertmanagerConfig:
    resources:
      requests:
        cpu: 200m
        memory: 1Gi

I didn't create a ticket in JIRA but I can do later.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the .spec.resources field and the Prometheus and Alertmanager configuration APIs in the operator. Verify how resource requests are currently applied, then define how each resource is configured independently and ensure the API description matches the behavior. Done means Prometheus and Alertmanager requests can be set separately without the misleading shared field.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
api, devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.