rhobs / rhobs/observability-operator

Reconciler fails to Patch at random

Open
#200 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
51
Forks
90
Avg merge
5d 15h
Merged PRs (30d)
22

Description

Related to #181 .

We sometimes also see that reconciler fails to Patch. The issue seem to be that the Patch tries to update a non-existent resource when it should actually be creating it.

E.g. - https://github.com/rhobs/observability-operator/actions/runs/3232742256/jobs/5294131669#step:4:989

2022-10-12T07:58:40Z	INFO	observability-operator	Reconciling monitoring stack	{"stack": "e2e-tests/valid-loglevel"}
2022-10-12T07:58:40Z	INFO	thanos-querier	watched MonitoringStack changed, checking for matching querier	{"Monitoring Stack": "e2e-tests/valid-loglevel"}
2022-10-12T07:58:41Z	INFO	observability-operator	patch failed	{"stack": "e2e-tests/valid-loglevel", "reconciler": "updater", "name": "valid-loglevel-alertmanager", "ns": "e2e-tests", "error": "roles.rbac.authorization.k8s.io \"valid-loglevel-alertmanager\" not found"}
2022-10-12T07:58:41Z	INFO	observability-operator	Failed to get prometheus object	{"stack": "e2e-tests/valid-loglevel", "err": "Prometheus.monitoring.rhobs \"valid-loglevel\" not found"}
2022-10-12T07:58:41Z	ERROR	Reconciler error	{"controller": "monitoringstack", "controllerGroup": "monitoring.rhobs", "controllerKind": "MonitoringStack", "monitoringStack": {"name":"valid-loglevel","namespace":"e2e-tests"}, "namespace": "e2e-tests", "name": "valid-loglevel", "reconcileID": "45436353-5cee-45b0-947f-aefeed0e2d0a", "error": "roles.rbac.authorization.k8s.io \"valid-loglevel-alertmanager\" not found"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/internal/controller/controller.go:273
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/internal/controller/controller.go:234
2022-10-12T07:58:41Z	INFO	observability-operator	Reconciling monitoring stack	{"stack": "e2e-tests/valid-loglevel"}
2022-10-12T07:58:51Z	INFO	observability-operator	Reconciling monitoring stack	{"stack": "e2e-tests/valid-retention"}
2022-10-12T07:58:51Z	INFO	thanos-querier	watched MonitoringStack changed, checking for matching querier	{"Monitoring Stack": "e2e-tests/valid-retention"}
2022-10-12T07:58:51Z	INFO	observability-operator	patch failed	{"stack": "e2e-tests/valid-retention", "reconciler": "updater", "name": "valid-retention-alertmanager", "ns": "e2e-tests", "error": "roles.rbac.authorization.k8s.io \"valid-retention-alertmanager\" not found"}
2022-10-12T07:58:51Z	INFO	observability-operator	Failed to get prometheus object	{"stack": "e2e-tests/valid-retention", "err": "Prometheus.monitoring.rhobs \"valid-retention\" not found"}
2022-10-12T07:58:51Z	ERROR	Reconciler error	{"controller": "monitoringstack", "controllerGroup": "monitoring.rhobs", "controllerKind": "MonitoringStack", "monitoringStack": {"name":"valid-retention","namespace":"e2e-tests"}, "namespace": "e2e-tests", "name": "valid-retention", "reconcileID": "6fd51d0c-50e2-4618-9107-5419858c5a50", "error": "roles.rbac.authorization.k8s.io \"valid-retention-alertmanager\" not found"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/internal/controller/controller.go:273
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/internal/controller/controller.go:234
2022-10-12T07:58:51Z	INFO	observability-operator	Reconciling monitoring stack	{"stack": "e2e-tests/valid-retention"}
2022-10-12T07:58:51Z	INFO	observability-operator	Reconciling monitoring stack	{"stack": "e2e-tests/valid-retention"}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the monitoringstack reconciler's Patch path and compare it with the behavior described in related issue #181. Use the linked GitHub Actions logs to understand the missing Role and Prometheus resources; done means reconciliation creates absent resources instead of failing when Patch is attempted.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.