Insecure password storage
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 1.1k
- Forks
- 348
- PR merge metrics
- No merged PRs in 30d
Description
It looks like in several places mokmanager tries to read plaintext passwords (such as from MokSB and MokDB) to enable certain behavior. This isn't a secure way to store passwords and shouldn't be used. I was tipped off to this by the fact that mokutil gave me a maximum password length, but if I were less careful, I might have used a valuable password like a disk encryption password.
Granted, it's mokutil that's writing the password, but since mokmanager is the party consuming it, mokmanager is the one that should set the standards for secure passwords.
Absent a compelling reason otherwise, please consider implementing only properly hashed passwords. It looks like there's already support for standard crypt methods elsewhere, so this shouldn't be difficult to do.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing where mokmanager consumes passwords from MokSB and MokDB, then review the existing standard crypt support mentioned in the issue. The work is complete when password handling no longer relies on plaintext storage while the affected behavior remains supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems, security
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100