restify / restify/node-restify

Gzip plugin prevents text/event-stream from working

Open
#820 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Critical Help Wanted Unconfirmed
Dominant language
JavaScript
Stars
10.7k
Forks
975
Avg merge
1d 6h
Merged PRs (30d)
5

Description

I have to call

      res.handledGzip && res.handledGzip();
      res.removeHeader('Content-Encoding');

in my SSE plugin to bypass the Gzip plugin—otherwise EventSource fails.

The solution would involve adding support for keep alive connection in the Gzip plugin.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Gzip plugin and the handling for text/event-stream or SSE; the issue does not name files or tests. Reproduce the failure with EventSource and compare it with the shown workaround. Done means keep-alive SSE connections work without manually calling handledGzip or removing Content-Encoding.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.