restify / restify/node-restify

Please upgrade `formidable` to latest (v3 /v4)

Open
#1,985 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
10.7k
Forks
975
Avg merge
1d 6h
Merged PRs (30d)
5

Description

Lead maintainer of formidable here.

Any particular reason why you're using v1? You're using pretty old and flaky version, with obscure APIs.

Please upgrade to latest, and prepare for v4 which is written in TypeScript and modern stack & APIs like Fetch/Request/Response/ReadableStream, and there is no buffering or writing to disk. You can try the formidable@next dist-tag.

Trying to ditch people of the v1 for years, yet it has 2 million downloads and many vulnerabilities.
Trying to narrow down from where these 2M are coming from and how much should we care about that version.

I'm seeing you're using it for testing only, but still. Everything except v3 is deprecated and vulnerable.
At least migrate to v3, it still has CJS support if that's a must. Tho, the v4 have both CJS & ESM too and work down to Node v14.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the test-only formidable v1 dependency and every usage of its API. Compare those usages with the formidable v3 and v4 migration requirements, choose a supported target, and verify that the test suite still passes without deprecated or vulnerable v1 behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.