restify / restify/node-restify

route params for methods other than GET should work for second part of the path

Open
#1,887 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
10.7k
Forks
975
Avg merge
1d 6h
Merged PRs (30d)
5

Description

  • Used appropriate template for the issue type
  • Searched both open and closed issues for duplicates of this issue
  • Title adequately and concisely reflects the feature or the bug

Restify Version: 8.6.0
Node.js Version: 16.9.1

Expected behaviour

route params for methods other than GET should work for second part of the path: eg.

/api/:entity/user/password

Actual behaviour

it fails to find the route

Repro case

use the following route and try to hit that route:

/api/:entity/user/password

it will not find the route.

Cause

not certain; was working in v5.2.0

Are you willing and able to fix this?

no. don't have the time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the route /api/:entity/user/password with a non-GET request on Restify 8.6.0, then compare its behavior with v5.2.0. Trace the route-matching entry point to determine why the parameterized second path segment is not found. Done means the route resolves correctly for methods other than GET.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.