Incorrect typings. makeConstructor returns void but it should return a constructor
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 144
- Forks
- 30
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 6
Description
I am getting TS errors when using errors.makeConstructor().
In your type definitions it is:
export function makeConstructor(name: string, defaults?: any): void;
But according to the docs makeConstructor should return a constructor.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the type definition for makeConstructor and compare its declared return type with the documentation behavior described in the issue. Update the declaration so it reflects the returned constructor, then verify that the reported TypeScript errors are resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100