look at whitelisting of some HTTP proxy headers in `proxyOptsFromStr`
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 58
- Forks
- 35
- Avg merge
- 22h 4m
- Merged PRs (30d)
- 10
Description
From work on restify/node-restify#878 and #85. HTTP proxy support is in lib/HttpClient.js. Note that the request module does some whitelisting of req.headers for proxying. Restify-clients should look at doing the same... and finding refs to authoritative docs/RFCs on that.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/HttpClient.js at proxyOptsFromStr, then compare the request module’s proxy-header whitelisting and the context in restify/node-restify#878 and #85. Consult authoritative HTTP/RFC references for which headers may be forwarded, and define completion as restify-clients applying an equivalent documented whitelist.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100