restify / restify/clients

Request bodies ignored by restify clients on DELETE requests

Open
#165 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
58
Forks
35
Avg merge
22h 4m
Merged PRs (30d)
10

Description

Moved from: https://github.com/restify/node-restify/issues/742

The HTTP spec allows for DELETE request bodies, and the restify server works with DELETE request bodies, but the restify clients' del method doesn't allow a payload as an argument.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the restify clients' del method and its argument handling, then compare it with the server's support for DELETE request bodies. Done means del accepts and sends a payload for DELETE requests, with the client behavior covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.