restify / restify/clients

json client, wrong content-type on delete method

Open
#163 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
58
Forks
35
Avg merge
22h 4m
Merged PRs (30d)
10

Description

MOVED FROM: https://github.com/restify/node-restify/issues/539

Using latest restify (2.6.1) when json client makes http DELETE request it sets content-type to application/octet-stream instead application/json.

Check out this gist:
https://gist.github.com/spikhoff/9229833

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked gist and trace the JsonClient DELETE request path in this repository to find where its Content-Type is selected. Confirm the behavior against the reported restify 2.6.1 case; done means JSON DELETE requests use application/json rather than application/octet-stream.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.