rest-for-physics / rest-for-physics/tracklib
Independent track analysis for pure 3D tracks with XYZ hits
@JPorron is already working on this.
Since Feb 23, 2024.
- Dominant language
- C
- Stars
- 2
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Recently there was some issues with XYZ tracks reported by @DavidDiezIb , and addressed also in https://github.com/rest-for-physics/tracklib/pull/39.
It is a bit strange for me that in the following code lines https://github.com/rest-for-physics/tracklib/blob/6b3c09c3cf538f8ca714544f5427fc085f0aa9bf/src/TRestTrackAnalysisProcess.cxx#L972
the XZ and YZ hits are combined to produce XYZ observables.
Indeed, this is likely producing XYZ observables out of XZ and YZ hits. However, the pure XYZ hits might require dedicated attention. Also, the TrackAnalysis process is becoming too wide.
I think we should favor smaller and more atomic processes that target a reduced problem.
We could for instance have TRestTrack3DAnalysisProcess that will target only pure XYZ tracks produced with pixel readouts or pure MC simulation output. This process would serve only for those events that contain pure XYZ tracks, so there should be some error output in case we find other track types inside the input event.
Also, we may think to split into TRestTrackBasicAnalysisProcess and TRestTrack2DAnalysisProcess, etc.
I think atomic processes should be favored.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.