rest-for-physics / rest-for-physics/rawlib
`TRestRawSignal` should use unsigned short instead of signed short
Open
- Dominant language
- C++
- Stars
- 2
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
This has been discussed a few times already: signal data should be stored as unsigned integer instead of a signed integer as it better represents ADC units.
The change is easy to do but it might break many things so it should be done carefully.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the TRestRawSignal entry point and inspect linked pull request #116 to understand the proposed type change. Audit the affected signal-data consumers for signed-value assumptions and confirm that the change does not break supported binary formats or processing routines.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100