rest-for-physics / rest-for-physics/framework

TRestMapGroup and TRestMapGroupProcess implementation

Open
#64 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

  • #83 by @KonradAltenmueller — closed without merging
development enhancement
Dominant language
C++
Stars
19
Forks
14
PR merge metrics
No merged PRs in 30d

Description

It would be good to design and implement a generic process that would allow to perform calculations on a selection of elements inside a std::map.

The most clear example right now is when I have a system of vetos covering the detector. Those vetos are registered as signals, analysed using TRestRawSignalAnalysisProcess and few observables written together into std::map variables at the analysis tree. Thats the validation pipeline introduced at rest-for-physics/rawlib#25.

Now, I want to be able to define groups of signals, so that I would be able to define a subset of signal ids over which I will perform some calculations. So TRestMapGroup would allow me to give a name to the group and define the elements from std::map.first that belong to that group. I would be able to define any number of groups. This is somehow done now at TRestRawVetoAnalysisProcess.

TRestMapGroupProcess would allow me to use a TRestMapGroup definition to perform calculations on the specific subsets. The user would define at the process level which operations wants to be performed on the subset, i.e. average, max value, deviation, etc.

Those calculated values would be written to the process as pcsName_groupName_average, pcsName_groupName_deviation, ...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing TRestRawVetoAnalysisProcess and TRestRawSignalAnalysisProcess to understand the existing grouping and analysis behavior, then inspect linked pull request #83. Done would mean an agreed design and implementation for named std::map groups, configurable subset calculations, and the specified output naming scheme.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.