rest-for-physics / rest-for-physics/framework
Merging datasets is not properly handled
Open
@juanangp is already working on this.
Since Oct 5, 2023.
- Dominant language
- C++
- Stars
- 19
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
I found an issue merging datasets using TRestDataSet::Import function implemented here:
https://github.com/rest-for-physics/framework/blob/9c2fae713e932c11c23efc78e332bdac2e3dad5e/source/framework/core/src/TRestDataSet.cxx#L952
Although the trees are properly merged the metadata has issues, for instance while merging two datasets the duration is not properly retreived.
I guess we should implement a TRestDataSet merging of the metadata to solve this issue
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.