rest-for-physics / rest-for-physics/framework

Error building for macOS

Open
#482 0 comments 0 reactions 0 assignees View on GitHub

@lobis is already working on this.

Since Sep 26, 2023.

  • #483 by @lobis — open
cmake
Dominant language
C++
Stars
19
Forks
14
PR merge metrics
No merged PRs in 30d

Description

I was unable to compile the REST-for-Physics framework on a macbook (M1).

There are some errors related to the TRestHits_Iterator class. Looks like these were warnings on previous version of (cmake, gcc, something like that) but now are errors.

I tried fixing some of them but I could not fix all (yet).

❯ g++ --version
Apple clang version 15.0.0 (clang-1500.0.40.1)
Target: arm64-apple-darwin22.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
❯ cmake --version
cmake version 3.27.6

CMake suite maintained and supported by Kitware (kitware.com/cmake).
❯ root-config --version
6.29.01
❯ uname -a
Darwin luis-macbook.local 22.6.0 Darwin Kernel Version 22.6.0: Fri Sep 15 13:41:30 PDT 2023; root:xnu-8796.141.3.700.8~1/RELEASE_ARM64_T8103 arm64

Sample error:

In file included from /Users/lobis/git/framework/source/libraries/detector/src/TRestDetectorHitsEvent.cxx:40:
In file included from /Users/lobis/git/framework/source/libraries/detector/inc/TRestDetectorHitsEvent.h:5:
In file included from /Users/lobis/opt/root/include/TAxis.h:24:
In file included from /Users/lobis/opt/root/include/TNamed.h:25:
In file included from /Users/lobis/opt/root/include/TObject.h:17:
In file included from /Users/lobis/opt/root/include/Rtypes.h:193:
In file included from /Users/lobis/opt/root/include/TGenericClassInfo.h:21:
In file included from /Users/lobis/opt/root/include/TSchemaHelper.h:17:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/string:576:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/string_view:1025:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/algorithm:1757:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/__algorithm/make_heap.h:15:
/Library/Developer/CommandLineTools/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/__algorithm/sift_down.h:44:34: error: no matching function for call to object of type '(lambda at /Users/lobis/git/framework/source/libraries/detector/src/TRestDetectorHitsEvent.cxx:143:19)'
    if ((__child + 1) < __len && __comp(*__child_i, *(__child_i + difference_type(1)))) {

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with TRestDetectorHitsEvent.cxx, especially the lambda at line 143, and inspect the TRestHits_Iterator-related errors when building on the reported M1 macOS environment. Reproduce the build with the listed CMake, ROOT, and Apple Clang versions; done means the REST-for-Physics framework compiles successfully without these errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp, macos
Domain
build-system, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.