rest-for-physics / rest-for-physics/framework
Adding units to metadata filter conditions
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 19
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
When defining a new dataset, the metadata filter conditions do not accept units yet. Thus, the values there must be given on standard REST units, keV, mm, us, ...
I believe here we would need to implement something like TRestMetadata::GetFieldValueWithUnits such as it is done for metadata parameters.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing metadata filter condition handling with TRestMetadata::GetFieldValueWithUnits, which the issue identifies as the model used for metadata parameters. Trace the existing filter-condition entry point and determine how unit-bearing values should be interpreted; the work is done when conditions accept units such as keV, mm, and us instead of requiring standard REST units.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100