rest-for-physics / rest-for-physics/framework
GitHub Actions framework cache not working as expected
- Dominant language
- C++
- Stars
- 19
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
When debugging the following PR: https://github.com/rest-for-physics/framework/pull/365 I found an error in the GitHub Actions workflow.
It seems that the caching of the framework is instead restoring the cache (because a key already exists) but this should be unique each workflow run, so this should not happen. One can see this in the following run:
https://github.com/rest-for-physics/framework/actions/runs/4913830534/jobs/8774448343
In particular the workflow is failing because the installation directory for Garfield differs between Docker images, the installation with the correct image is not being saved into the cache because the key is already populated.
I guess we should use a more robust cache key identifier so this cannot happen.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.