rest-for-physics / rest-for-physics/framework
Automatic PR at framework after submodule PR
Open
@juanangp is already working on this.
Since Apr 27, 2023.
enhancement
policy
- Dominant language
- C++
- Stars
- 19
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
Looking at the issues on validation that we had recently, I think a new workflow for the PR is required. Here my proposal:
- PR on
submodulestrigger the creation of a PR onframeworkand the submodule hash is updated accordingly in framework. If the PR of the same branch already exist in framework with the same branch name it just commit the changes on the submodule hash. For instance, something similar is done at https://github.com/releasehub-com/github-action-create-pr-parent-submodule - PR can only be merged from
frameworkand it will automatically trigger thesubmodule, this can address this issue https://github.com/rest-for-physics/framework/issues/250 since some work has been done here https://github.com/rest-for-physics/framework/pull/259 - The pipeline validation will only run at
frameworkso we avoid to trigger the pipeline when a PR is performed in e.g. different submodules and in framework.
@jgalan and @lobis let me know what do you think since this is a lot of work.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.